Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

locales without '_' produce runtime error #22

Closed
bibor opened this issue Nov 12, 2017 · 0 comments
Closed

locales without '_' produce runtime error #22

bibor opened this issue Nov 12, 2017 · 0 comments

Comments

@bibor
Copy link

bibor commented Nov 12, 2017

"POSIX" or "C" are valid locales, but will produce a runtime error, because they don't contain '_'.
This is because of line 98: "Accept-Language": self.deviceBuilder.locale.replace('_', '-')

I would suggest to check it after line 55: if locale is not None:
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bibor