Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add healthcheck to operator container #240

Open
Hyodar opened this issue Jun 6, 2024 · 3 comments
Open

Add healthcheck to operator container #240

Hyodar opened this issue Jun 6, 2024 · 3 comments

Comments

@Hyodar
Copy link
Contributor

Hyodar commented Jun 6, 2024

We have an external healthcheck in the docker compose environment, but it'd be nice to have it directly in the image.

@Hyodar
Copy link
Contributor Author

Hyodar commented Jun 7, 2024

Once we do this, then the test from #244 should be changed to check the health of the operator services directly

@mikhailUshakoff
Copy link
Contributor

I'm unsure whether we should include a health check inside the container. I don't see any benefits from it. Moving the logic from the health container to the operator container wouldn't change anything. Perhaps we should consider a more sophisticated health check algorithm.

@Hyodar
Copy link
Contributor Author

Hyodar commented Jul 1, 2024

Hey, this is mostly a best practices thing. The container itself should have a general way for you to check if it`s healthy or not - you can always override it, but overall a separate service is not ideal. We did have a separate service before since our container had only the bare minimum infra.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants