-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: make graceful daemon shutdown exit with code 0 #504
Conversation
Good point. I'm no longer sure why I let it exit with code 1 to be honest. But I tested for it xD! Exiting with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #504 +/- ##
===============================================
+ Coverage 80.15% 80.16% +0.01%
===============================================
Files 77 77
Lines 5673 5673
===============================================
+ Hits 4547 4548 +1
+ Misses 1126 1125 -1 ☔ View full report in Codecov by Sentry. |
Classic changelog merge conflict -.- I really have to look at automated changelogs at some point. |
When shutting down pueued using SIGINT or SIGTERM then the exit code should be zero. This is necessary, for example, when running as a systemd service since systemd will otherwise put the service in a failed state whenever it shuts down.
Cool, thanks! I've rebased the branch with the conflict resolved. |
Thanks! |
Thank you! I'll have to release a new version soon with these changes :D |
That would be great, much appreciated! |
Description
When shutting down pueued using SIGINT or SIGTERM then the exit code should be zero. This is necessary, for example, when running as a systemd service since systemd will otherwise put the service in a failed state whenever it shuts down.
I'm not sure why it is currently exiting with an error-code. Maybe it is for some good reason? But looking at the code comments it definitely mentions exiting gracefully, which I would interpret as exit code 0.
Checklist
CHANGELOG.md
.cargo clippy
andcargo fmt
. The CI will fail otherwise anyway.