-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add dark mode support to the HTML versions of the OpenAPI specs #3866
Comments
Paging @Bellangelo (we're working on making it so that we can assign issues to you, but haven't quite sorted that out yet). |
Unfortunately, this seems not to be so easy. Our |
ReSpec documentation of dark mode says
We can enable the switch, and it has no effect 😞 |
@mikekistler Don't know what changed in the last two weeks, now dark mode seems to work (at least if your system theme is set to dark mode): Quite some fine-tuning needed for dark mode to really work:
I'll gladly leave this to someone fluent in CSS 😁 |
I have started on this, please assign to my name. Intermediate results can be seen here: https://pavelkornev.github.io/OpenAPI-Specification/oas/latest.html |
Hi @pavelkornev, I used some of your CSS in this PR to continue on this work. If you have already a PR that I missed then I can close mine and use yours instead. |
The approach i tried won't work because then switcher between Dark/Light mode doesn't work properly. Try both scenarious:
|
Thanks a lot @pavelkornev for your feedback ❤ . I had encapsulated the styling under the |
Update the rendering process for the HTML versions of the OpenAPI specs (using ReSpec) to generate pages that support dark mode.
ReSpec has added dark mode support: speced/respec#2651
Related: #3576
The text was updated successfully, but these errors were encountered: