Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Question: How Does OCA Distribute and Update Pre-Commit Rules? #637

Open
yibudak opened this issue Dec 26, 2024 · 2 comments
Open

Question: How Does OCA Distribute and Update Pre-Commit Rules? #637

yibudak opened this issue Dec 26, 2024 · 2 comments

Comments

@yibudak
Copy link

yibudak commented Dec 26, 2024

Hello,

I noticed that in the 16.0 branch of the OCA/crm repository, the pylint-odoo version specified in the pre-commit configuration is 8.0.19, while the latest release is currently 9.2.0.

I’m curious about the update strategy for these pre-commit checks. Will the version of pylint-odoo be updated eventually in the 16.0 branch, or is 8.0.19 intentionally fixed for this branch?

Thanks.

@yibudak yibudak changed the title Question: How OCA Distribute Pre-commit Rules? Question: How OCA Distribute pre-commit Rules? Dec 26, 2024
@yibudak yibudak changed the title Question: How OCA Distribute pre-commit Rules? Question: How Does OCA Distribute and Update Pre-Commit Rules? Dec 26, 2024
@pedrobaeza
Copy link
Member

Versions are normally pinned for existing branches, and reviewed when a new version arises, pulling that new linter versions only for this new branch. The reason is to keep maximum compatibility with existing merged code (as the new linter version may bring some new checks that can turn the branch red). If any critical aspect requires the version bumping, then it can be discussed and incorporated.

@yibudak
Copy link
Author

yibudak commented Dec 26, 2024

Thank you for the clarification, @pedrobaeza.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants