Closes #149, vocabulary_version no longer required #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clair can you clarify this: In the V5.3.1 release the field is still required. The current vocabularies we download do have missing values so cannot be loaded. |
|
Hi @PRijnbeek in v5.3.1 the field VOCABULARY.VOCABULARY_VERSION is not required. Is it listed as required in the version of the ddl you are using? |
|
Hi @clairblacketer . Both the github wiki and PDF from the v5.3.1 release archive have this column as required. Also the Oracle DDL from the v5.3.1 release has |
clairblacketer
added a commit
that referenced
this pull request
Apr 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vocabulary_version, which was changed to required. It is now back to 'not required' as not every vocabulary has version information