-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Location History Table #181
Comments
Instead of entity_id can we call it entity_concept_id |
@gowthamrao I don't know that entity_concept_id would fit, the idea is that the field would house something like a person_id or a care_site_id |
Thank you for the clarification. |
reopening this since it has not yet been added to the cdm |
Initially posted here 5d26033 @clairblacketer @cgreich @pbr6cornell The location_history table is going to be an extremely large (EAV) like table. Currently we have two varchar(30) columns
Can we convert these to integers - using concept_id i.e. instead of relationship_type, change to relationship_type_concept_id Integers would be expected to lead to better performance, I think. Plus, it would achieve the same end-goal that the CDM WG wants to represents in this table. |
@gowthamrao we are going to discuss changing all domain_id references to table_concept_id at the September CDM meeting. I agree it would help cut down on confusion where two tables have the same domain. |
@rtmill how do you feel about the relationship_type_concept_id field? |
I agree with both. |
@clairblacketer @gowthamrao @cgreich That was the plan for relationship_type (create a small vocabulary) and I agree it also makes sense for domain_id. This seems similar to the way domains are represented in the FACT_RELATIONSHIP table? then it would be: The question I remember during the proposal was whether or not we should include relationship_type_source_value. |
@rtmill from the proposal it looks like there will only be four options for relationship_type_concept_id ('residence', 'work site', 'school', NULL) so I don't see the need for a *source_value field. We can always add it later if the use case comes up. In terms of domain_concept_id, we will most likely be moving to table_concept_id instead as there are multiple tables with the same domain (visit_occurrence, visit_detail) which makes it tricky for other tables that reference domain, like COST. For now we will keep it as domain_id until a decision is made on 9/4. |
added in v6.0 |
This is a link to the location history table proposal on the GIS githhub page. This proposal was accepted on 5/10/2018 and will be added to an upcoming version of the cdm.
The text was updated successfully, but these errors were encountered: