Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] Cannot load images in TMTV or Segmentation mode with local datasource #4585

Open
sen-trenser opened this issue Dec 10, 2024 · 5 comments
Labels
Bug Verified Bug reported, reproducible, and verified.

Comments

@sen-trenser
Copy link

sen-trenser commented Dec 10, 2024

Describe the Bug

Loading TMTV mode with local folder as datasource is not working in demo sites.
The same happens for segmentation mode with SEG files. Data opens in segmentation mode without any SEG file, but breaks as soon as we add a new segmentation.

An exception is thrown from extensions/default/src/getPTImageIdInstanceMetadata.ts as it cannot provide metadata for local datasource image ID.

  if (!dicomMetaData) {
    throw new Error('dicom metadata are required');
  }

This seems to be broken from 3.9.1 tag and also exists in the nightly build demo viewer.

Steps to Reproduce

Go to https://viewer.ohif.org/local and load a folder with PET and CT images
Open the study in TMTV mode from the study list page.

The current behavior

TMTV mode shows the below error and all vewports are blank.
Image

The expected behavior

TMTV mode should open the study and display images

OS

Ubuntu 24.04

Node version

18.19.0

Browser

Chrome 131.0.6778.108

@sen-trenser sen-trenser added the Awaiting Reproduction Can we reproduce the reported bug? label Dec 10, 2024
Copy link
Member

sedghi commented Dec 10, 2024

Does the same data work in regular mode?

@sen-trenser
Copy link
Author

@sedghi We checked the same data in 3.8 and it loads in TMTV mode.
None of the CT-PT data we have is loading in TMTV mode with OHIF local datasource.

Here is an example data from TCIA manifest file: manifest-1733899117169.zip

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Dec 12, 2024
@sedghi sedghi added the Bug Verified Bug reported, reproducible, and verified. label Dec 12, 2024 — with Linear
@sen-trenser sen-trenser changed the title [Bug] Cannot load images in TMTV mode with local datasource [Bug] Cannot load images in TMTV or Segmentation mode with local datasource Dec 13, 2024
@sen-trenser
Copy link
Author

@sedghi The same happens for segmentation mode with image series and its SEG files loading via local datasource.

DICOM image series opens in segmentation mode without any SEG file, but it breaks as soon as we add a new segmentation.

@ashik-trenser
Copy link

@sedghi This issue seems to be due to the change in the case of SOPInstanceUID in normal metadata and local data source metadata. Here is the area from which the code is breaking due to the mentioned issue.

@sedghi
Copy link
Member

sedghi commented Dec 13, 2024

ok we will look

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Verified Bug reported, reproducible, and verified.
Projects
None yet
Development

No branches or pull requests

3 participants