Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tidy pre processor options #10

Open
simonrp84 opened this issue Sep 30, 2018 · 2 comments
Open

Tidy pre processor options #10

simonrp84 opened this issue Sep 30, 2018 · 2 comments
Assignees

Comments

@simonrp84
Copy link
Collaborator

The ORAC pre-processor contains multiple options, set through the parse_optional subroutine (utils_for_main.F90) based on what's in the driver file. This means we're passing huge numbers of variables between options, which is untidy.
An 'optional variables' struct would tidy this up and make the code more readable.

@simonrp84 simonrp84 self-assigned this Sep 30, 2018
@adamcpovey
Copy link
Collaborator

The code that generates the parser for the main processor was designed to be general and create multiple parsers. We should probably tidy the preprocessor and putting all the options in an equivalent to the Ctrl structure will help make a better parser.

@simonrp84
Copy link
Collaborator Author

I'm working on this now, have created a "preproc_opts" type that contains all the option variables (plus ecmwf filenames, etc).

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants