Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not throw error on empty approved review #46

Merged
merged 1 commit into from
Feb 18, 2025
+8 −1
Merged

Do not throw error on empty approved review #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,14 @@ function pathListToMarkdown(files) {
}

function getPayloadBody() {
const body = context.payload.comment ? context.payload.comment.body : context.payload.review.body
let body = context.payload.comment ? context.payload.comment.body : context.payload.review.body
/**
* Of the three ways to review code ("commented", "approved", "changes_requested"), only
* "approved" can have a "null" body. For that case, ignore instead of throw error.
*/
if (context.payload?.review?.state === 'approved' && body === null) {
body = ''
}
if (body == null) {
throw new Error(`No body found, ${JSON.stringify(context)}`)
}
Expand Down