Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Report cuts off dataflows in the diagram #1141

Open
jgadsden opened this issue Dec 14, 2024 · 2 comments
Open

Report cuts off dataflows in the diagram #1141

jgadsden opened this issue Dec 14, 2024 · 2 comments
Labels
bug Something isn't working priority version-2.4
Milestone

Comments

@jgadsden
Copy link
Collaborator

jgadsden commented Dec 14, 2024

Describe the bug:

when 2.3.0 is used to create a report from a model model created in 2.2.0, the bottom is cut off:

threat-dragon-report-cut-off

Same thing happens when a PDF report is created

threat-dragon-report

This was not the case in 2.2.0:

Expected behaviour:

The report shows the complete / full diagram

Environment:

  • Version: 2.3.0 (and not in 2.2.0)
  • Platform: Web App
  • OS: any
  • Browser: any of chrome, firefox, safari

To Reproduce:

  1. create a new threat model diagram
  2. add two nodes to the diagram - any of Actor, Data Store or Process
  3. connect a dataflow between the two nodes
  4. make the data flow go beyond the bottom edges of the nodes
  5. create a report - either PDF or HTML

Workaround:

Ensure that the dataflow is above the lowest line of the diagram nodes

@jgadsden jgadsden added bug Something isn't working version-2.3.1 labels Dec 14, 2024
@jgadsden jgadsden added this to the Version 2.3.1 milestone Dec 14, 2024
@jgadsden jgadsden changed the title Report cuts off some of the diagram Report cuts off dataflows in the diagram Dec 14, 2024
@jgadsden
Copy link
Collaborator Author

The cause of this bug may be linked to issue #1041 , the symptoms are different but it may have the same underlying cause

@jgadsden
Copy link
Collaborator Author

this is probably due to the incompatibility between AntV/X6 and Vue2, and needs to be tested with Vue 3 (subject of issue #444 )

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working priority version-2.4
Projects
None yet
Development

No branches or pull requests

1 participant