Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add CancellationToken support on async calls #537

Open
brianfeucht opened this issue Jul 7, 2020 · 4 comments
Open

Add CancellationToken support on async calls #537

brianfeucht opened this issue Jul 7, 2020 · 4 comments

Comments

@brianfeucht
Copy link

It is considered a best practice to provide a CancellationToken to allow for the cancellation of tasks.

It doesn't appear that any of the async code in this library has any support for passing in a CancellationToken. This means if a query end up being long running there is no way for the caller to abort a request. This can cause problems for things like Windows Services where the expectation is to respond quickly to shutdown requests.

@yj7o5
Copy link

yj7o5 commented Oct 4, 2020

Hi @droyad, I have been lately using this client at work and have noticed the absence of CancellationToken can I take a stab at the following issue?

@matt-richardson
Copy link
Contributor

Hi @yj7o5 - sure, go for it! PRs definitely appreciated 👍

@yj7o5
Copy link

yj7o5 commented Oct 6, 2020

Thanks guys, feel free to assign it to me and I'll get the PR in a day or two. :)

@yj7o5
Copy link

yj7o5 commented Oct 10, 2020

@matt-richardson PR submitted for your review! Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants