Error notification when LocationPaths is missing .dll file(s)

[marcospgp]

Is there any way we can get an error when one of the LocationPaths does not contain a .dll? Otherwise it's relatively easy for analyzers to silently stop working.

[bjorkstromm]

Looking at the code and currently no.

I'd say an error might probably be too intrusive, but maybe a warning or at least a debug log could be added.

Relevant code is around here:

omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/ExternalFeaturesHostServicesProvider.cs

Lines 17 to 32 in aa1018c

	[ImportingConstructor]
	public ExternalFeaturesHostServicesProvider(IAssemblyLoader loader, OmniSharpOptions options, IOmniSharpEnvironment environment)
	{
	var builder = ImmutableArray.CreateBuilder<Assembly>();
	var roslynExtensionsLocations = options.RoslynExtensionsOptions.GetNormalizedLocationPaths(environment);
	if (roslynExtensionsLocations?.Any() == true)
	{
	foreach (var roslynExtensionsLocation in roslynExtensionsLocations)
	{
	builder.AddRange(loader.LoadAllFrom(roslynExtensionsLocation));
	}
	}
	Assemblies = builder.ToImmutable();
	}

omnisharp-roslyn/src/OmniSharp.Shared/Options/RoslynExtensionsOptions.cs

Lines 21 to 40 in aa1018c

	public IEnumerable<string> GetNormalizedLocationPaths(IOmniSharpEnvironment env)
	{
	if (LocationPaths == null || LocationPaths.Length == 0) return Enumerable.Empty<string>();
	var normalizePaths = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
	foreach (var locationPath in LocationPaths)
	{
	if (Path.IsPathRooted(locationPath))
	{
	normalizePaths.Add(locationPath);
	}
	else
	{
	normalizePaths.Add(Path.Combine(env.TargetDirectory, locationPath));
	}
	}
	return normalizePaths;
	}
	}

omnisharp-roslyn/src/OmniSharp.Host/Services/AssemblyLoader.cs

Lines 38 to 62 in aa1018c

	public IReadOnlyList<Assembly> LoadAllFrom(string folderPath)
	{
	if (string.IsNullOrWhiteSpace(folderPath)) return Array.Empty<Assembly>();
	try
	{
	var assemblies = new List<Assembly>();
	foreach (var filePath in Directory.EnumerateFiles(folderPath, "*.dll"))
	{
	var assembly = LoadFrom(filePath);
	if (assembly != null)
	{
	assemblies.Add(assembly);
	}
	}
	return assemblies;
	}
	catch (Exception ex)
	{
	_logger.LogError(ex, $"An error occurred when attempting to access '{folderPath}'.");
	return Array.Empty<Assembly>();
	}
	}

Thoughts, @filipw @david-driscoll?