Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve build file #14

Merged

Conversation

NonSwag
Copy link

@NonSwag NonSwag commented Jun 7, 2024

Description

this is not a technical change
it only brings structure to the unorganized build.gradle.kts

summary:

  • reformatted indentations
  • replaced java code with kotlin where possible
  • removed ugly and unnecessary line breaks
  • added line breaks to clearly distinct different jobs
  • removed unused repository
  • shortened repository references
  • use source/target compatibility instead of toolchain language version
  • replaced gradle tasks with their respective references instead of using named

Checklist

  • I included all information required in the sections above
  • I tested my changes and approved their functionality
  • I ensured my changes do not break other parts of the code

@NonSwag NonSwag requested a review from TheMeinerLP as a code owner June 7, 2024 16:56
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@TheMeinerLP TheMeinerLP changed the title Renovate build file Improve build file Jun 7, 2024
Copy link
Collaborator

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheMeinerLP TheMeinerLP merged commit cfdb62e into OneLiteFeatherNET:master Jun 7, 2024
6 checks passed
@NonSwag NonSwag deleted the renovate-build-file branch June 7, 2024 19:37
@TheMeinerLP TheMeinerLP mentioned this pull request Dec 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants