Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DevilutionX: Assets are included twice #24

Open
AJenbo opened this issue Nov 12, 2023 · 4 comments
Open

DevilutionX: Assets are included twice #24

AJenbo opened this issue Nov 12, 2023 · 4 comments

Comments

@AJenbo
Copy link

AJenbo commented Nov 12, 2023

Hi, I see you have both the assets and the devilutionx.mpq file included in this distribution.

The content of devilutionx.mpq is just the files form the assets folder so you actually do not need both. Removing one should help you get rid of a few MB :)

@schmurtzm
Copy link
Member

Hi, in the official documentation they mention to get the release (which contains the "assets" folder) and the "devilutionx.mpq" so I'm not sure...
The "assets" is only 10MB anyway...

@AJenbo
Copy link
Author

AJenbo commented Nov 13, 2023

Sorry if the official documentation is not clear...:
image

But to be fair you are looking at the installation instructions and so fare as I understand you are doing a build from source. In which case the relevant section is here: https://github.com/diasurgical/devilutionX/blob/master/docs/building.md#if-you-want-to-build-the-devilutionxmpq-file-optional

To be clear, devilutionx.mpq is basically a zip file containing the assets folder. Which is more convenient then managing all the individual files.

The engine prefers devilutionx.mpq over the assets folder so the list of required files can be simplified to the following without affecting anyone:

Directory tree for "Diablo (DevilutionX)"
|
|   devilutionx
|   devilutionx.mpq
|   DIABDAT.MPQ
|   hellfire.mpq
|   hfmonk.mpq
|   hfmusic.mpq
|   hfvoice.mpq
|   _required_files.txt
|   
\---lib
        libSDL-1.2.so.0

(hellfire.mpq, hfmonk.mpq, hfmusic.mpq, hfvoice.mpq are only needed for enabling the Hellfire expansion)

@schmurtzm
Copy link
Member

Ahah I see that you probably know what you are talking about 😄
The first releases were build but now that you propose Miyoo builds I take your official builds (so the asset folder is already here)

I will remove the assets folder and give better details in « required » files 😉

@AJenbo
Copy link
Author

AJenbo commented Nov 14, 2023

Let me know if I can be helpful

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants