Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bug: cannot add tags to bookmarks #1

Open
hchaase opened this issue Apr 10, 2017 · 4 comments
Open

bug: cannot add tags to bookmarks #1

hchaase opened this issue Apr 10, 2017 · 4 comments

Comments

@hchaase
Copy link
Contributor

hchaase commented Apr 10, 2017

Hi
I enjoy the plugin, but for some reason I cannot add tags any more. It worked in the beginning.

I get the red error screen when I press the add button :(
The text I write in the tag field is typed if i open the created bookmark (or any tiddler) but not added as a tag.

billede

I have updated to the version from your plug-in library.

@inmysocks
Copy link
Member

I will be able to look into this in the next few days.

@shibco
Copy link

shibco commented Feb 10, 2023

Following up on this, I'm experiencing this issue too!

@shibco
Copy link

shibco commented Feb 10, 2023

I took a few minutes to look into this. Since the issue is dead, I might as well document the fix here:
The issue occurs when a Bookmark is cancelled in certain circumstances and a temporary Tiddler remains. The Tiddler, which is either $:/data/Bookmarks/BookmarkTags or $:/temp/NewTagName, will already exist when it shouldn't as a Tiddler with the contents of 1, and nothing else. The plugin assumes that the tiddler doesn't exist, and instead of overwriting the Tiddler, the plugin's design assumes that it will never encounter this existing temp tiddler and fail. The temp fix is to delete the existing Tiddler.

I didn't take a note of the name of the tiddler when I did this. I think it's $:/data/Bookmarks/BookmarkTags, but removing $:/temp/NewTagName shouldn't harm your wiki either. Make sure you back up!

@shibco
Copy link

shibco commented Feb 11, 2023

Actually, my solution above doesn't work at all. This plugin is very easy to break.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants