Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NFR004 - key mgt #30

Closed
bluesteens opened this issue Mar 24, 2023 · 4 comments · Fixed by #86
Closed

NFR004 - key mgt #30

bluesteens opened this issue Mar 24, 2023 · 4 comments · Fixed by #86
Assignees
Labels
documentation Improvements or additions to documentation Steering - Review Proposal and Completed work must be reviewed by Steering.

Comments

@bluesteens
Copy link
Member

bluesteens commented Mar 24, 2023

Steering summary:
Unclear wording around wallet security aspects. Suggest to reword to avoid ambiguity.


It is not entirely clear whether this NFR is to deals only with keys in relation to the DID document or also provider app-specific security.

It says under Conformance Criteria

  • Solution SHALL provide secure key management for encryption and signing keys
    -Solution SHALL provide features to update DID documents and to rotate keys in accordance with the W3C DID standards and best practices/implementation guidelines on a regular basis, keys SHALL be rotated no less often than once every 12 months.
  • Solution SHALL provide rotation features for encryption keys (e.g. database encryption, certificate renewal)

The last bullet reads as if it was meant to address sth like API keys for a provider app. The rest seems to apply to DID docs.

OCI should consider splitting both scopes into 2 NFR or making it clearer within this 004 what is meant.

@bluesteens bluesteens added the documentation Improvements or additions to documentation label Mar 24, 2023
@bluesteens
Copy link
Member Author

bluesteens commented Mar 24, 2023

  • Is Issue appropriate for OCI Architecture
  • Create Steering-level Summary of request
  • Assign Size
  • Assign Priority
  • Assign Label (if needed)
  • OCI affected Artifacts Identified
  • Assign Triage - Artifact Version Target (v x.x.x Milestone)
  • Assign Triage - Interop Profile Version Target (v x.x.x Milestone)
  • Create sub-project (if needed)

Affected Parties (help determine Sunrise/Sunset):

  • Trading Partners
  • Issuers
  • Wallet Solutions
  • PI Verification Solutions

@rceleste125 rceleste125 added the Steering - Review Proposal and Completed work must be reviewed by Steering. label Jul 17, 2023
@bluesteens
Copy link
Member Author

bluesteens commented Jul 27, 2023

Mtg July 27:
also consider specifying what happens to rotated keys (deleted, retired)

  • deletion complicates re-verifiability of old VC and thus makes auditability of past events difficult. reliance would need to be placed on historical database records
  • P&A leans towards not deleting keys and instead retiring them

@bluesteens
Copy link
Member Author

consider adding that key rotation is only required for PROD accounts/usage

@bluesteens bluesteens linked a pull request Aug 23, 2023 that will close this issue
@bluesteens bluesteens changed the title NFR004 - unclear scope NFR004 Sep 11, 2023
@bluesteens bluesteens changed the title NFR004 NFR004 - key mgt Sep 11, 2023
@bluesteens
Copy link
Member Author

14.9. P&A: edits to make text work for both DID methods
persisted in the DID document = discoverable via the DID document

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation Steering - Review Proposal and Completed work must be reviewed by Steering.
Projects
Status: Done - Published
Development

Successfully merging a pull request may close this issue.

3 participants