Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tutorial videos on readthedocs are too wide #2462

Closed
matrss opened this issue Aug 15, 2024 · 5 comments
Closed

Tutorial videos on readthedocs are too wide #2462

matrss opened this issue Aug 15, 2024 · 5 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@matrss
Copy link
Collaborator

matrss commented Aug 15, 2024

See for example:

Screenshot from 2024-08-15 13-55-43

and:

IMG_20240815_135658

I think the videos should not exceed the width of the browser window itself, at all times. If they are too small one can always make them full-screen as needed.

@ReimarBauer
Copy link
Member

The videos should behave identical to the image in about.

@matrss
Copy link
Collaborator Author

matrss commented Aug 15, 2024

That image has max-width: 100% set, but it is already not that wide, so it is below 100%. Do you want the videos to be similar in width to that image, or limited to 100% at most like that image?

@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 15, 2024

The image has a size 1200x900 and it is scaled by the theme.
You see its original size by opening it in its own tab.

Screenshot_20240815_154026_Chrome.jpg

We need to find the class Attribute and look if this works with the videos too or define some own css.

@matrss
Copy link
Collaborator Author

matrss commented Aug 15, 2024

Yes, my question was if you want videos exactly as wide as that image, i.e. max(1200px, 100% width), or just have videos be limited by the enclosing blocks width as well, like that image.

For reference, this is how that image looks on my desktop:

Screenshot from 2024-08-15 16-09-35

It is less than 100% width, because the images own width is smaller.

The CSS to do this for videos as well is trivial.

@ReimarBauer
Copy link
Member

ReimarBauer commented Aug 15, 2024

Yes, my question was if you want videos exactly as wide as that image, i.e. max(1200px, 100% width), or just have videos be limited by the enclosing blocks width as well, like that image.

For reference, this is how that image looks on my desktop:

Screenshot from 2024-08-15 16-09-35

It is less than 100% width, because the images own width is smaller.

The CSS to do this for videos as well is trivial.

The only thing I want is that it behaves responsive. It must work on any resolution of the browser.

@ReimarBauer ReimarBauer added the bug Something isn't working label Aug 15, 2024
@ReimarBauer ReimarBauer added this to the 9.1.1 milestone Aug 15, 2024
@ReimarBauer ReimarBauer added the documentation Improvements or additions to documentation label Aug 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants