Skip to content

Commit 9dad5b8

Browse files
authored
False positive diff for array with maxItems fix (#785)
* False positive diff for array with maxItems fix * fix: correct comparison logic in ChangedMaxItems and ChangedMinItems
1 parent 5b82a8b commit 9dad5b8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMaxItems.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.openapitools.openapidiff.core.model.schema;
22

3+
import java.util.Objects;
34
import org.openapitools.openapidiff.core.model.Changed;
45
import org.openapitools.openapidiff.core.model.DiffContext;
56
import org.openapitools.openapidiff.core.model.DiffResult;
@@ -17,7 +18,7 @@ public ChangedMaxItems(Integer oldValue, Integer newValue, DiffContext context)
1718

1819
@Override
1920
public DiffResult isChanged() {
20-
if (oldValue == newValue) {
21+
if (Objects.equals(oldValue, newValue)) {
2122
return DiffResult.NO_CHANGES;
2223
}
2324
if (oldValue == null || newValue == null) {

core/src/main/java/org/openapitools/openapidiff/core/model/schema/ChangedMinItems.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package org.openapitools.openapidiff.core.model.schema;
22

3+
import java.util.Objects;
34
import org.openapitools.openapidiff.core.model.Changed;
45
import org.openapitools.openapidiff.core.model.DiffContext;
56
import org.openapitools.openapidiff.core.model.DiffResult;
@@ -17,7 +18,7 @@ public ChangedMinItems(Integer oldValue, Integer newValue, DiffContext context)
1718

1819
@Override
1920
public DiffResult isChanged() {
20-
if (oldValue == newValue) {
21+
if (Objects.equals(oldValue, newValue)) {
2122
return DiffResult.NO_CHANGES;
2223
}
2324
if (oldValue == null || newValue == null) {

0 commit comments

Comments
 (0)