[malwarebazaar-recent-additions] Allow optional storage of malware samples #3503
+157
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The core intent of this update is to support the "optional" storage of the malware files related to the Malware Bazaar data fetches. Some users may not wish to "actually" store the "real" malware files on their system disk. This could be due to security requirements, or could be because they never use the actual file and it is needlessly increasing their S3/MinIO storage requirements. This update allows for access to the Artifact entries and metadata about the malware artifacts - but removes the storage of the "real" malware when enabled. The malware is replaced with a file that is 85 bytes in size and when downloaded within OpenCTI states:
"This would normally be Malware, but we have disabled the saving of the real malware."
Changes:
Cleaned up code for autopep8/black/isort/pylint compliance.
Added the following in the
docker-compose.yml
to show connector values could be in theconfig.yml
or here and added the missing Auth-Key token reference that is required for the connector to function properly.docker-compose.yml
andconfig.yml.sample
in order to support NOT actually storing the real malware in S3/MinIO storage.Related issues
Checklist
Further comments
N/A