Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Dragos]: feat implement api client #3505

Open
wants to merge 15 commits into
base: feat/2570-dragos-create-the-connector
Choose a base branch
from
Open

[Dragos]: feat implement api client #3505

wants to merge 15 commits into from

Conversation

flavienSindou
Copy link
Contributor

@flavienSindou flavienSindou commented Feb 26, 2025 •
edited
Loading

Proposed changes

  • implement Dragos V1 API client to be later used in an adapter, implementing report interface
  • ASIDE: fix a typing error in report interface

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Related Notion Page : https://www.notion.so/filigran/Integration-Dragos-Create-the-connector-1528fce17f2a80dda61ed990b8e78b75?pvs=4

@flavienSindou flavienSindou self-assigned this Feb 26, 2025
@flavienSindou flavienSindou added feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team labels Feb 26, 2025
flavienSindou
flavienSindou commented Feb 26, 2025
View reviewed changes
external-import/dragos/dragos/interfaces/report.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASIDE : Minor typing fix

flavienSindou
flavienSindou commented Feb 26, 2025
View reviewed changes
external-import/dragos/client_api/v1/__init__.py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core of the PR

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Powlinett Powlinett Awaiting requested review from Powlinett

Assignees

@flavienSindou flavienSindou

Labels
feature use for describing a new feature to develop filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flavienSindou