Skip to content

Commit 1cfa09f

Browse files
GagziWkimmyeonghun
authored and
kimmyeonghun
committed
p2p: changed if-else blocks to conform with golint (ethereum#16660)
1 parent c5c650b commit 1cfa09f

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

p2p/message.go

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -229,21 +229,20 @@ func ExpectMsg(r MsgReader, code uint64, content interface{}) error {
229229
}
230230
if content == nil {
231231
return msg.Discard()
232-
} else {
233-
contentEnc, err := rlp.EncodeToBytes(content)
234-
if err != nil {
235-
panic("content encode error: " + err.Error())
236-
}
237-
if int(msg.Size) != len(contentEnc) {
238-
return fmt.Errorf("message size mismatch: got %d, want %d", msg.Size, len(contentEnc))
239-
}
240-
actualContent, err := ioutil.ReadAll(msg.Payload)
241-
if err != nil {
242-
return err
243-
}
244-
if !bytes.Equal(actualContent, contentEnc) {
245-
return fmt.Errorf("message payload mismatch:\ngot: %x\nwant: %x", actualContent, contentEnc)
246-
}
232+
}
233+
contentEnc, err := rlp.EncodeToBytes(content)
234+
if err != nil {
235+
panic("content encode error: " + err.Error())
236+
}
237+
if int(msg.Size) != len(contentEnc) {
238+
return fmt.Errorf("message size mismatch: got %d, want %d", msg.Size, len(contentEnc))
239+
}
240+
actualContent, err := ioutil.ReadAll(msg.Payload)
241+
if err != nil {
242+
return err
243+
}
244+
if !bytes.Equal(actualContent, contentEnc) {
245+
return fmt.Errorf("message payload mismatch:\ngot: %x\nwant: %x", actualContent, contentEnc)
247246
}
248247
return nil
249248
}

p2p/simulations/network.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,6 @@ func (self *Network) executeNodeEvent(e *Event) error {
738738
func (self *Network) executeConnEvent(e *Event) error {
739739
if e.Conn.Up {
740740
return self.Connect(e.Conn.One, e.Conn.Other)
741-
} else {
742-
return self.Disconnect(e.Conn.One, e.Conn.Other)
743741
}
742+
return self.Disconnect(e.Conn.One, e.Conn.Other)
744743
}

0 commit comments

Comments
 (0)