New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove the message type check from the publisher #256

Open

pavel-kirienko opened this issue Nov 9, 2022 · 0 comments

Labels

class-feature domain-core help wanted severity-minor

Member

pavel-kirienko commented Nov 9, 2022

This check is unnecessarily restrictive as it makes it impossible to publish sub/supertypes:

pycyphal/pycyphal/presentation/_port/_publisher.py

Lines 182 to 183 in 8273967

    
           if not isinstance(message, self.dtype): 
        
               raise TypeError(f"Expected a message object of type {self.dtype}, found this: {message}")

pavel-kirienko added help wanted severity-minor class-feature domain-core labels

# for free to join this conversation on GitHub. Already have an account? # to comment