Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug?] in definition of areal solar energy density #1981

Closed
5 tasks done
ColinHDev opened this issue Dec 2, 2024 · 3 comments · Fixed by #1983
Closed
5 tasks done

[bug?] in definition of areal solar energy density #1981

ColinHDev opened this issue Dec 2, 2024 · 3 comments · Fixed by #1983
Assignees
Labels
[C] definition update Update an ontology definition in discussion Issues being discussed by users and/or maintainers

Comments

@ColinHDev
Copy link
Member

Description of the issue

The class areal solar energy density has the definition An areal solar energy density is an areal energy density that gives the arriving solar power per area. A synonym for areal solar power density is irradiation.

Shouldn't this instead read An areal solar energy density is an areal energy density that gives the arriving solar energy per area. A synonym for areal solar energy density is irradiation.?

To me it looks like a copy-pasting error from the similar class areal solar power density with the similar definition of An areal solar power density is an areal power density that indicates the arriving solar power per area. A synonym for areal solar power density is irradiance.

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@ColinHDev ColinHDev added [C] definition update Update an ontology definition To do Issues that haven't got discussed yet labels Dec 2, 2024
@stap-m stap-m moved this to To do in Issues Dec 2, 2024
@stap-m stap-m added this to Issues Dec 2, 2024
@stap-m stap-m changed the title Possible error in definition of areal solar energy density [bug?] in definition of areal solar energy density Dec 3, 2024
@stap-m stap-m added this to the oeo-release-2.6.0 milestone Dec 3, 2024
@stap-m
Copy link
Contributor

stap-m commented Dec 3, 2024

@carstenhoyerklick could you take a look please?

@carstenhoyerklick
Copy link
Contributor

Yes, it looks like an error. Irradiation is energy, Irradiance is power.

An areal solar energy density is an areal energy density that gives the arriving solar energy per area. A synonym for areal solar energy density is irradiation.

would be correct.

@stap-m
Copy link
Contributor

stap-m commented Dec 3, 2024

@ColinHDev please create a PR to fix.

@github-actions github-actions bot added in discussion Issues being discussed by users and/or maintainers and removed To do Issues that haven't got discussed yet labels Dec 3, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Issues Dec 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[C] definition update Update an ontology definition in discussion Issues being discussed by users and/or maintainers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants