Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

kobotoolbox: baseURL -> baseUrl #985

Closed
josephjclark opened this issue Feb 5, 2025 · 0 comments
Closed

kobotoolbox: baseURL -> baseUrl #985

josephjclark opened this issue Feb 5, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request P1 Priority Level

Comments

@josephjclark
Copy link
Collaborator

The kobotoolbox baseURL configuration should be renamed to baseUrl

Literally every other adaptor uses baseUrl. It's just this one that's different.

To preserve old credentials, I think it's worth supporting baseURL, but undocumented. Let's log a warning if baseURL is removed

Treat this as a breaking change.

So:

  • Rename baseURL to baseURL in config and code
  • In code, if baseUrl is not set and baseURL is provided, use baseURL but log a warning
  • Major changeset
@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 5, 2025
@hunterachieng hunterachieng added enhancement New feature or request adaptor labels Feb 6, 2025
@martalovescoffee martalovescoffee added the P1 Priority Level label Feb 7, 2025
@github-project-automation github-project-automation bot moved this from New Issues to Done in v2 Feb 10, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request P1 Priority Level
Projects
Status: Done
Development

No branches or pull requests

3 participants