Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Catalog price rules core bug in Magento CE 1.9.1 and EE 1.14.1.0 #25

Closed
real34 opened this issue Jun 23, 2015 · 9 comments
Closed

Catalog price rules core bug in Magento CE 1.9.1 and EE 1.14.1.0 #25

real34 opened this issue Jun 23, 2015 · 9 comments
Labels
bug

Comments

@real34
Copy link
Contributor

real34 commented Jun 23, 2015

See http://firebearstudio.com/blog/catalog-price-rules-core-bug-in-magento-ce-1-9-1-and-ee-1-14-1-0-array-to-string-conversion-error-and-incorrect-price-rules-behavior.html for further information and a patch

So far the issue is still "In progress" on magento bug tracker: http://www.magentocommerce.com/bug-tracking/issue/index/id/278
Is this the kind of things that you'd like to include? What would be the process then?
@Flyingmana
Copy link
Contributor

Yes, that is a thing we would want to include.
We are still in a process to create a CI setup, so we can also add additional tests to reproduce the Bugs and validate the fixes are working.

Till then I think an accept from two members of the team is what it needs. In this case could it need a little longer, as they need to find the time trying it out and reviewing it.

@drobinson
Copy link
Collaborator

@real34 I know this is old, but if you'd like to include this patch will you submit a PR?

@seansan
Copy link
Contributor

seansan commented Oct 11, 2016

@real34 any update on this?

@tomekjordan
Copy link

will it be fixed?

@tomekjordan tomekjordan mentioned this issue Feb 22, 2017
Closed
@sreichel
Copy link
Contributor

sreichel commented Mar 2, 2017

Was fixed in 1.9.2.0.

@tmotyl
Copy link
Contributor

tmotyl commented Mar 15, 2017

@sreichel I assume you've tested the issue with newer magento and found it's fixed. I'm closing the issue.

@tmotyl tmotyl closed this as completed Mar 15, 2017
@sreichel
Copy link
Contributor

Yep. Tested on 1.9.3.1 and looked where code hasr changed .

@sreichel sreichel mentioned this issue Sep 1, 2017
Closed
@seansan seansan mentioned this issue Dec 4, 2017
Closed
@matteotestoni matteotestoni mentioned this issue Mar 16, 2023
Closed
@andyt andyt mentioned this issue Apr 24, 2023
Closed
sreichel referenced this issue in openmage-strict/openmage-future Feb 20, 2024
@sreichel @fballiano
Some phpstan fixes in Mage_Adminhtml (#25)
17c182e 
* Mage_Adminhtml_Block_Catalog_Product_Helper_Form_Gallery

* Mage_Adminhtml_Block_Report_Grid_Abstract

* Mage_Adminhtml_Block_Report_Sales_Coupons_Grid

* Mage_Adminhtml_Block_Dashboard_Graph

* Mage_Adminhtml_Block_Notification_Grid_Renderer_Severity

* Mage_Adminhtml_Block_Sales_Order_Shipment_Packaging

* Mage_Adminhtml_Block_System_Store_Edit

* Mage_Adminhtml_Block_System_Store_Edit_Form

* Fixed sonar issues

---------

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
@sreichel
Copy link
Contributor

sreichel commented Feb 4, 2025

@all-contributors add @real34 bug

@allcontributors allcontributors bot mentioned this issue Feb 4, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@sreichel

I've put up a pull request to add @real34! 🎉

@OnyXxL OnyXxL mentioned this issue Feb 23, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@real34 @Flyingmana @drobinson @tmotyl @seansan @sreichel @tomekjordan