Support for Portable PDBs in server project

[aivanov-oneinc]

Hello team!

We use OpenRIaServices for generating a WCF RIA Client. We're going for optimizing our server-side build artifacts and turn on <DebugType>portable</DebugType> It allows decreasing output size in about 10 times, it is more modern and useful. But suddenly we found that OpenRiaService is unable to generate the correct client (*.g.cs) in that case.

Preconditions:

1. On the server, we have an enumeration with our custom attributes
2. Server project references a library with custom attributes
3. Enumerations members have custom attributes on them
4. Custom attributes classes declared in .shared. files in DLL compiled with [<DebugType>portable</DebugType>].

Expected result: We have our custom attributes generated on a client

Actual result: On running MSBuild CreateOpenRiaClientFilesTask client-generated proxy does not contain those custom attributes.

Suggestion

Our investigation also leads us to the existing dotnet community-supported library for symbols reading is https://github.com/dotnet/symreader-portable I think it is good to consider replacing your implementations of ISymbol* interfaces with https://github.com/dotnet/symreader-portable .

I will be really glad to see this working in your library.

[Daniel-Svensson]

Supporting the portable fortmat would be god to have, especially if we want to make it easier to use netstandard/netcoreapp libraries. I haven't researched if the portable symreader also support the "full"/windows pdb format. Portable pdb should might also be usable when .net 4.7.2+ is installed using some opt in mechanism according to portable pdb docs but I dont know if that would be applicable to the current code

I would gladly accept a PR with support for portable pdbs alongside the currently supported format.
This would fit very for the 5.0 release #178

[Daniel-Svensson]

You could maybe also look at the System.Reflection.Metadata which is an alternativ, but it will probably require a little more effort.

update it also looks like https://github.com/dotnet/symreader should support both "full" and portable