Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add sort functionality for poll lists #30

Open
markusphil opened this issue Oct 5, 2019 · 4 comments
Open

Add sort functionality for poll lists #30

markusphil opened this issue Oct 5, 2019 · 4 comments
Labels
good first issue Good for newcomers

Comments

@markusphil
Copy link
Collaborator

I already implemented sorting options for the questionlist and created some helperfunctions. This could be easily adopted for the poll / template list.

But maybe you have a better idea for the sorting functionality =)

@AnBusse
Copy link

AnBusse commented Oct 5, 2019

Hi, I'd like to give this issue a shot

@markusphil
Copy link
Collaborator Author

Of course! just go ahead and let me know if you encounter any problems 😊

@AnBusse
Copy link

AnBusse commented Oct 6, 2019

@markusphil so I have the app up and running locally. I'd like to get the requirements right:
I see a basic filtering is implemented on the poll list already (see screenshot attached). You mention a question list that has the desired filtering already, but while I can see the view file QuestionList.vue I can't seem to find it used in the application right now, is that correct?
Screenshot_2019-10-06 poll-app

@markusphil
Copy link
Collaborator Author

markusphil commented Oct 7, 2019

I tried to generalize the "FilterBar" so it can be used with all available lists. The sort and filter logic itself is contained in the list components. The QuestionList.vue file is one of this components and it is used on the CreatePoll.vue View (it's the list on the left side).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants