Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

final tidying up (including redirects) #44

Open
jules32 opened this issue Jun 26, 2023 · 7 comments
Open

final tidying up (including redirects) #44

jules32 opened this issue Jun 26, 2023 · 7 comments

Comments

@jules32
Copy link
Contributor

jules32 commented Jun 26, 2023

Hi @samanthacsik ,

Are there final tidying things we should be thinking about and do?

One thing is about the _redirects file, should we delete it since netlify.toml underlies the redirects? I also noticed that there's till an issue with trailing \s despite pages like code-of-conduct/ being included in the netlify.toml https://github.com/Openscapes/website-new/blob/main/netlify.toml#L23-L26

@samanthacsik
Copy link
Collaborator

samanthacsik commented Jun 27, 2023

@jules32 okay, I looked into this trailing / thing a bit more and this support guide -- [Support Guide] How can I alter trailing slash behaviour in my URLs? Will enabling Pretty URLs help? -- offers a lot of insight

Two takeaways:

"To start, redirects cannot be used to alter trailing slash behaviour 19"

"In summary, you’re probably not going to want to untick pretty URLs in our UI."

Screen Shot 2023-06-27 at 10 18 32 AM

We had turned off pretty URLs when we were troubleshooting the initial deployment -- maybe that's causing our issue here?

EDIT: Also addressing your questions re: deleting the _redirects file -- yes, I think for the sake of keeping things clean, we should delete that!

@samanthacsik
Copy link
Collaborator

samanthacsik commented Jun 27, 2023

Re: other stuff to tidy:

@jules32
Copy link
Contributor Author

jules32 commented Jun 27, 2023

Thanks @samanthacsik ! I updated Netlify with pretty urls and that issue is resolved (/code-of-conduct/ with trailing slash turns into /code-of-conduct)

@jules32
Copy link
Contributor Author

jules32 commented Jun 27, 2023

Thanks for tidying these other things Sam!

For the Wiki, could you add:

  • adding redirects to netlify.toml (hopefully you can reuse a lot from your sleuthing issue!)

@jules32
Copy link
Contributor Author

jules32 commented Jun 27, 2023

Just deleted _redirects file: f756629

@samanthacsik
Copy link
Collaborator

@jules32 finished up a Wiki on redirects as well as one on Adding events! Created one about blockquotes a few days ago as well. I think this covers most of the major pieces, but if you ever run into something that you want documented this way, please do let me know :)

@jules32
Copy link
Contributor Author

jules32 commented Jun 29, 2023

Amazing, thank you so much Sam!!! Congratulations, such a beautiful and awesome website! 🌟

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants