diff --git a/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/BaseTriggerEventHandler.java b/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/BaseTriggerEventHandler.java index 3f3ce0830..0d4505280 100644 --- a/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/BaseTriggerEventHandler.java +++ b/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/BaseTriggerEventHandler.java @@ -69,14 +69,14 @@ public List getMatchingPipelines(T event, PipelineCache pipelineCache) log.debug("Start of the get matching Pipelines - BaseTriggerEventHandler"); boolean unstableTriggerEvent = isUnstableTriggerEvent(event); boolean successfulTriggerEvent = isSuccessfulTriggerEvent(event); - if (!unstableTriggerEvent || !successfulTriggerEvent) { + if (!unstableTriggerEvent && !successfulTriggerEvent) { return Collections.emptyList(); } Map> triggers = pipelineCache.getEnabledTriggersSync(); - List pipelines = new ArrayList<>(); if (successfulTriggerEvent) { + log.debug("successfulTriggerEvent - BaseTriggerEventHandler"); pipelines = supportedTriggerTypes().stream() .flatMap( @@ -92,9 +92,8 @@ public List getMatchingPipelines(T event, PipelineCache pipelineCache) .map(Optional::get) .distinct() .collect(Collectors.toList()); - } - - if (unstableTriggerEvent) { + } else if (unstableTriggerEvent) { + log.debug("unstableTriggerEvent - BaseTriggerEventHandler"); pipelines = (Optional.ofNullable(triggers.get(JENKINS_TRIGGER_TYPE)) .orElse(Collections.emptyList()) @@ -108,6 +107,7 @@ public List getMatchingPipelines(T event, PipelineCache pipelineCache) .distinct() .collect(Collectors.toList()); } + log.debug("pipelinesData" + pipelines); log.debug("End of the get matching Pipelines - BaseTriggerEventHandler"); return pipelines; } diff --git a/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/ManualEventHandler.java b/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/ManualEventHandler.java index 3c79957e5..3ebdf3e7a 100644 --- a/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/ManualEventHandler.java +++ b/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/ManualEventHandler.java @@ -108,19 +108,12 @@ public List getMatchingPipelines(ManualEvent event, PipelineCache pipe log.debug("Start of the get matching Pipelines - ManualTriggerEventHandler"); boolean unstableTriggerEvent = isUnstableTriggerEvent(event); boolean successfulTriggerEvent = isSuccessfulTriggerEvent(event); - if (!unstableTriggerEvent || !successfulTriggerEvent) { + if (!unstableTriggerEvent && !successfulTriggerEvent) { return Collections.emptyList(); } List pipelines = new ArrayList<>(); - if (successfulTriggerEvent) { - pipelines = - pipelineCache.getPipelinesSync().stream() - .map(p -> withMatchingTrigger(event, p)) - .filter(Optional::isPresent) - .map(Optional::get) - .collect(Collectors.toList()); - } - if (unstableTriggerEvent && isJenkinsBuildTriggerAndUnstableBuild(event)) { + if (successfulTriggerEvent + || (unstableTriggerEvent && isJenkinsBuildTriggerAndUnstableBuild(event))) { pipelines = pipelineCache.getPipelinesSync().stream() .map(p -> withMatchingTrigger(event, p)) diff --git a/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/TriggerEventHandler.java b/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/TriggerEventHandler.java index c425cf9f8..6279e6eb5 100644 --- a/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/TriggerEventHandler.java +++ b/echo-pipelinetriggers/src/main/java/com/netflix/spinnaker/echo/pipelinetriggers/eventhandlers/TriggerEventHandler.java @@ -73,6 +73,6 @@ default boolean isSuccessfulTriggerEvent(T event) { } default boolean isUnstableTriggerEvent(T event) { - return true; + return false; } }