Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Asset Manager - min action Sourcemaps #17573

Merged
merged 3 commits into from
Mar 8, 2025
Merged

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Mar 7, 2025

Apply same logic than with Parcel.

min.js --> minified for prod
.js --> minified with .map reference

This way we don't need to change any script tag.
This will fix the issue where some assets are returning a 404 on source maps.

Skrypt added 3 commits March 7, 2025 01:28
Apply same logic than with Parcel.

min.js --> minified for prod
.js --> minified with .map reference

This way we don't need to change any script tag.
@Skrypt Skrypt requested review from gvkries and MikeAlhayek March 7, 2025 16:32
@Skrypt Skrypt merged commit 9d204d0 into main Mar 8, 2025
7 checks passed
@Skrypt Skrypt deleted the skrypt/asset-manager-min-sm branch March 8, 2025 15:35
@MikeAlhayek
Copy link
Member

@Skrypt so many changes to the assets manager. I think it would be a good idea to do an update "like a demo" on Tuesday with all the changes. You should demo the following:

  • How to build assets.
  • How to add new packages and bundle new files.
  • How to write scripts moving forward using import and why we should follow this technique.
  • How can one copy the same setup into their project if needed?

I think this will help the maintainer without having to spend lots of time to get themself up to speed. We can this share the recording in the docs page. So if you can, plan for a full demo so if someone sees it for the first time, they know all about the Asset Management suite we are using.

@Skrypt
Copy link
Contributor Author

Skrypt commented Mar 9, 2025

Ok, there is already documentation that should work but I can maybe show how to get going quickly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants