Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

SFCGAL 1.2.1 release invalid -- patch version was not changed #116

Closed
robe2 opened this issue Nov 15, 2015 · 7 comments
Closed

SFCGAL 1.2.1 release invalid -- patch version was not changed #116

robe2 opened this issue Nov 15, 2015 · 7 comments

Comments

@robe2
Copy link
Contributor

robe2 commented Nov 15, 2015

The SFCGAL 1.2.1 release (and root) still have SFCGAL version reading 1.2.0

The CMakeLists file was never changed to reflect the new version.

https://github.com/Oslandia/SFCGAL/blob/master/CMakeLists.txt

@mhugo
Copy link
Contributor

mhugo commented Nov 16, 2015

True ... sorry for that. I'll release a 1.2.2

@mhugo
Copy link
Contributor

mhugo commented Nov 16, 2015

SFCGAL 1.2.2 is out wich fixed CMakeLists.txt

@mhugo mhugo closed this as completed Nov 16, 2015
@robe2
Copy link
Contributor Author

robe2 commented Nov 16, 2015

Now I'm going to be a nitpick -- your release notes don't mention that this very important issue was patched - #111

@strk
Copy link

strk commented Nov 16, 2015

also, the 1.2.3 milestone should be added and 1.2.2 removed (here on github)

@strk
Copy link

strk commented Nov 16, 2015

I've added the missing item in a commit to master (f385553)

@strk
Copy link

strk commented Nov 16, 2015

and I've also closed 1.2.2 milestone and created 1.2.3

@mhugo
Copy link
Contributor

mhugo commented Nov 17, 2015

@strk thanks. I've updated the github release notes

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants