Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ability to choose operator for Indicators growing_season_start/end #1794

Closed
1 of 2 tasks
nCarolina opened this issue Jun 25, 2024 · 2 comments · Fixed by #1796
Closed
1 of 2 tasks

Ability to choose operator for Indicators growing_season_start/end #1794

nCarolina opened this issue Jun 25, 2024 · 2 comments · Fixed by #1796
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nCarolina
Copy link

Addressing a Problem?

It would be nice to be able to choose which operator to use for the indicators growing_season_start/growing_season_end. This is possible for the growing_season_length indicator. However, I find it a bit confusing if the default operator ">=" corresponds to the definition under Notes with Tmean > 5 degC and Tmean < 5 degC or if the default behaviour is Tmean >= 5 degC and Tmean <= 5 degC.

Potential Solution

No response

Additional context

No response

Contribution

  • I would be willing/able to open a Pull Request to contribute this feature.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nCarolina nCarolina added the enhancement New feature or request label Jun 25, 2024
@aulemahal
Copy link
Collaborator

Hi @nCarolina!

Indeed, the same addition of the op argument of growing_season_length could be done to the other growing season indicators. FYI, >= is what is currently coded in the start and end functions,

And sorry for the confusing documentation, the default behaviour for growing_season_lenght is "T >= thresh" for a start and "T < thresh" (the boolean opposite) for an end.

@aulemahal aulemahal added this to the Summer 2024 milestone Jun 25, 2024
@Zeitsperre Zeitsperre self-assigned this Jun 25, 2024
@nCarolina
Copy link
Author

Thanks to both of you for this quick response to my request!

@aulemahal Okey, then I understand how it works!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants