Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] For some cities, current data is reported but historical data is not. Example: get_city_air('Kinshasa') returns a valid result, but get_historical_data(city='Kinshasa') reurns 'Exception: The search for city "Kinshasa" returns no result. It is possible that the city does not have AQI station.' #174

Open
jimfoundry opened this issue Jun 26, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@jimfoundry
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • OS: [e.g. MacOS]
  • Python version [e.g. 3.9.12]
  • Ozon3 Version [e.g. 1.7.1]
  • Execution Environment [e.g. Jupyter Notebook]

Additional context
Add any other context about the problem here.

@jimfoundry jimfoundry added the bug Something isn't working label Jun 26, 2023
@jimfoundry jimfoundry changed the title [BUG] For some cities, current data is reported but historical data is not. Example: get_city_air('Kinshasa') returns a valid result, but get_historical_data(city='Kinshasa') [BUG] For some cities, current data is reported but historical data is not. Example: get_city_air('Kinshasa') returns a valid result, but get_historical_data(city='Kinshasa') reurns 'Exception: The search for city "Kinshasa" returns no result. It is possible that the city does not have AQI station.' Jun 26, 2023
@github-actions
Copy link

Hey! Thanks for creating your first issue on Ozon3!

@Milind220
Copy link
Collaborator

Milind220 commented Jul 10, 2023

Hey @jimfoundry ! Thanks for creating this big report. It does seem like there isn't historical data available for every single city (though this is the first time I've ever seen this). Unfortunately, there isn't much we can do about the actual problem, as it depends on the underlying WAQI API's capabilities, and not on Ozon3.

However, we could improve the Ozon3 API so that at least a better error message/warning is displayed. Perhaps instead of crashing the program a warning could be better?

@hkafrawi
Copy link

hkafrawi commented Jan 6, 2024

@Milind220

If no one has worked on the error message/warning, Id like to work on that request.

A total beginner here in contribution to Open source and I would like this to be my first project!

@Milind220
Copy link
Collaborator

@hkafrawi If you're still keen, this is definitely a good, easy PR to try to make! We could definitely add warnings/error messages to indicate that some stations do not have data for all fields.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants