Created Dockerfile & Python File for the Application #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@RohanRusta21 Hey Rohan, I've reviewed your PR. Unfortunately, I don't think that dockerizing Ozon3, which is intended to be used simply as a Python library, is a good idea or helpful to the people who use it. As such I've decided to not merge your PR. Thank you anyways for putting in the effort to make the PR. |
Milind220
reviewed
Feb 10, 2024
| @@ -0,0 +1,14 @@ | |||
| # Use an official Python runtime as a parent image | |||
| FROM python:3.8 | |||
| MAINTAINER label="Rohan Rustagi" | |||
There was a problem hiding this comment.
LABEL maintainer="Rohan Rustagi" would be the modern way to write this
Milind220
reviewed
Feb 10, 2024
| WORKDIR /app | ||
|
|
||
| # Copy your Python script into the container | ||
| COPY *.py . |
There was a problem hiding this comment.
This wouldn't scale well with projects as they grow, as it indiscriminately copies all files from the build context into the docker image
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Milind220 @Miller2014 @lahdjirayhan @AliShahpurwala @Tomiiwa @ShootGan ,
I have created Dockerfile & Respective python code files which helps us the application to be get executed using cli commands. I have used Docker so that anyone can easily spin up the API in light weight containers without worrying about the installations of any external & 3rd part libraries. I hope this contribution is useful and valuable for the application. Also I have updated the README.md file with the steps so that anyone can easily follow them and use the application.
Please Review & Approve it :)
Thanks,
Rohan