SaveRecipes currently replaces the recipes

[1nf0rmagician]

The behaviour of the method was surprising at first site but I would not consider it a bug. My question is, do we want to adjust the method in the future? We shhould probably add a better comment do describe the behaviour, but do we need an extension method to just add a collection of recipes?

@dbeuchler, @Toxantron, @dacky179

MORYX-Framework/src/Moryx.Products.Management/Implementation/Storage/ProductStorage.cs

Line 235 in 944b02b

public void SaveRecipes(long productId, ICollection<IProductRecipe> recipes)

[dbeuchler]

What do you mean by "replaces the recepies"? The collection is not updated (maybe just the Id is set if 0)

[1nf0rmagician]

All recipes that are not in the collection given as a parameter are deleted from the database when you call that method. What I and @dacky179 expected, however, was that the given recipes would be added to the existing ones or update them.

[dbeuchler]

All recipes that are not in the collection given as a parameter are deleted from the database when you call that method

Ahh okay this is really missleading - I also would not expect that Save.. removes something. I would remove that from the method and provide a RemoveRecipes(recipes) method.

[Toxantron]

All recipes that are not in the collection given as a parameter are deleted from the database when you call that method

Ahh okay this is really missleading - I also would not expect that Save.. removes something. I would remove that from the method and provide a RemoveRecipes(recipes) method.

This would however break exisiting behavior. The original idea and usage of the old UI was:

1. GetRecipes(...)
2. Modifiy collection, remove, add und update objects
3. Call SaveRecipes

Somewhere from WCF internal endpoint to facade use Web endpoint we broke this. I generally agree though, Save should not delete things