-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
minor: Update PER set to v1.1 #6547
Conversation
3829eab
to
b02db11
Compare
63c375d
to
4923142
Compare
4923142
to
dcd7df0
Compare
a4b4aa7
to
0ba1aa1
Compare
The |
Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 14 days. Please keep your branch up-to-date by rebasing it when main branch is ahead of it, thanks in advance! |
PER-CS was released as 2.0, not 1.1. And per #6707, we're trying to restructure the way the PER-CS rules are defined anyway. Once that's in, though, this would make a reasonable starting point for the PER-CS 2.0 ruleset. |
This requires solid rebase after #6707 got merged, but personally I am not sure if it's good idea to provide all the changes in one PR. Maybe milestone would be better or issue with todo-list like here, but implemented with multiple smaller PRs? CC: @keradus @kubawerlos |
I noticed that Laravel Pint with the Is anyone working on this? I tried to figure out what's going on in this PR to see if I could help, but I think I've only caught some of the logic. It all looks too much for me. Maybe someone could create a milestone/issue with a more detailed to-do list (and maybe I could be helpful there). I think PER support is really important, and I want to start using it in my project as soon as possible. |
@asamofal There's #4502 for providing 100% coverage for PSR-12 / PER-CS v1. There's no other work for PER-CS v2 than this PR, which is outdated and should be closed IMHO. We should start with an issue or milestone, pointing all differences between v1 and v2 and implement it in steps, for easier review. This PR may help with determining scope, but I don't know if it's good to start with directly (rebasing, continuing work). |
I am going to close this in favor of #7247. |
protected_to_private
, but for enums onlyno_singleline_whitespace_before_semicolons
, but for arrow functions onlyfn
and=>
must be surrounded by a space=>
must be placed after a new line=>
must be indented once when placed after a new line