From 51635f6e83c400317d5c1896933debf4afa1c8e6 Mon Sep 17 00:00:00 2001
From: oleibman <10341515+oleibman@users.noreply.github.com>
Date: Mon, 6 Jan 2025 17:57:43 -0800
Subject: [PATCH] Remove Scrutinizer and Coverage from release1291 (#4304)

* Remove Scrutinizer and Coverage from release1291

Don't need them for backport releases.

* Add readthedocs.yaml

Unsure why it's needed.
---
 .github/workflows/main.yml | 35 -----------------------------------
 .readthedocs.yaml          | 12 ++++++++++++
 .scrutinizer.yml           | 30 ------------------------------
 3 files changed, 12 insertions(+), 65 deletions(-)
 create mode 100644 .readthedocs.yaml
 delete mode 100644 .scrutinizer.yml

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index f9932a29f6..faa5160ae0 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -216,41 +216,6 @@ jobs:
       - name: Static analysis with PHPStan
         run: ./vendor/bin/phpstan analyse
 
-  coverage:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Setup PHP, with composer and extensions
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: 8.3
-          extensions: ctype, dom, gd, iconv, fileinfo, libxml, mbstring, simplexml, xml, xmlreader, xmlwriter, zip, zlib
-          coverage: pcov
-
-      - name: Get composer cache directory
-        id: composer-cache
-        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
-
-      - name: Cache composer dependencies
-        uses: actions/cache@v4
-        with:
-          path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: ${{ runner.os }}-composer-
-
-      - name: Install dependencies
-        run: composer install --no-progress --prefer-dist --optimize-autoloader
-
-      - name: Coverage
-        run: |
-          ./vendor/bin/phpunit --coverage-clover coverage-clover.xml
-          composer global require scrutinizer/ocular
-          ~/.composer/vendor/bin/ocular code-coverage:upload --format=php-clover coverage-clover.xml
-
   release:
     runs-on: ubuntu-latest
     if: github.event_name == 'push' && contains(github.ref, 'refs/tags/')
diff --git a/.readthedocs.yaml b/.readthedocs.yaml
new file mode 100644
index 0000000000..c67101532d
--- /dev/null
+++ b/.readthedocs.yaml
@@ -0,0 +1,12 @@
+# Read the Docs configuration file for MkDocs projects
+# See https://docs.readthedocs.io/en/stable/config-file/v2.html
+
+version: 2
+
+build:
+    os: ubuntu-22.04
+    tools:
+        python: "3"
+
+mkdocs:
+    configuration: mkdocs.yml
diff --git a/.scrutinizer.yml b/.scrutinizer.yml
deleted file mode 100644
index c32d10407a..0000000000
--- a/.scrutinizer.yml
+++ /dev/null
@@ -1,30 +0,0 @@
-checks:
-    php: true
-
-coding_style:
-    php:
-        spaces:
-            before_parentheses:
-                closure_definition: true
-            around_operators:
-                concatenation: true
-
-build:
-    nodes:
-        analysis:
-            image: default-bionic
-            environment:
-                php: 8.1
-            tests:
-                override:
-                    - php-scrutinizer-run
-
-tools:
-    external_code_coverage:
-        timeout: 600
-
-build_failure_conditions:
-    - 'elements.rating(<= C).new.exists'                        # No new classes/methods with a rating of C or worse allowed
-    - 'issues.severity(>= MAJOR).new.exists'                    # New issues of major or higher severity
-    - 'project.metric_change("scrutinizer.test_coverage", < 0)' # Code Coverage decreased from previous inspection
-    - 'patches.label("Unused Use Statements").new.exists'       # No new unused imports patches allowed