Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Compiling pointops without THC #73

Open
maxim0815 opened this issue Jul 18, 2023 · 1 comment
Open

Compiling pointops without THC #73

maxim0815 opened this issue Jul 18, 2023 · 1 comment

Comments

@maxim0815
Copy link

Hey thanks for the code. I don't want to draw attention to a bug here, but just mention a small thing.

I just tried compiling pointops and ran into the following error:

src/knnquery/knnquery_cuda.cpp:2:10: fatal error: THC/THC.h: No such file or directory
    2 | #include <THC/THC.h>
      |          ^~~~~~~~~~~
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

According to this post "TH/THC namespace is dead". Removing the includes for THC within all .cpp files and recompiling works fine. It is therefore no longer required for newer cuda versions.

@JunbongJang
Copy link

Thank you!
I also encountered the same problem but your solution fixed it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants