-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SemVer policy? #1997
Comments
At least in my eyes, prql-compiler, language and all the bindings have the same versioning scheme. And we did discuss that even though sem-ver does not enforce it, we do not want to have breaking changes in patch releases (0.5.1 -> 0.5.2) and instead release a minor release (0.6). So, I do think that we should use semver for bindings too, but just bundle all three points into one versioning scheme. (And I don't think that #1993 is a breaking change - adding a field should not cause broken builds. Or am I wrong?) |
I would have thought that it did — constructing this Struct would break, matching on it without a |
I agree this would be good. If I'm correct about #1993, then we need to bump to 0.6.0 though, unless we adjust the definition a bit I am totally fine with either! I don't think we should be that worried about having too many minor releases. |
Considering the users who are using this downstream, I think it makes sense to inform them in a minor release that it contains breaking changes. https://github.com/apache/arrow, for example, is a monolipo, with major releases about every two months for all packages in the repository. Looking at the changelog at now, it doesn't seem to include any breaking changes, so 0.5.3 makes more sense for me. |
Then it is decided - the versioning scheme includes all three things together: language, compiler and all the bindings. Next release can be discussed in #2010 |
Yes we could have a section in the Changelog "Breaking changes", or we could just indicate which are breaking in the text — I'm easy either way... |
Currently we have a loose notion of Semantic Versioning. We could firm that up a bit. Which of these requires a new version:
prql-compiler
API — we don't really follow this at the moment — e.g. feat: error code #1993 technically breaks it, but i hadn't though we'd jump to 0.6 for thatprql-js
? This receives lots of bindings relative to the rust libraryThoughts?
The text was updated successfully, but these errors were encountered: