-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
【PIR Dist Op Reg No.2】 reg distributed_push_sparse #60805
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
…into PIR-optest-fix-2
…into PIR-optest-fix-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议补充一下单测
现在op注册时的output名称是output
output : Tensor[](output){ids.size()}
但是op_compat里面的配置是out,
- op : distributed_push_sparse
inputs :
{ids : Ids, shows : Shows, clicks: Clicks}
outputs :
out : Outputs
可以设置一下单测,确认一下能不能正确翻译
if (out == nullptr) { | ||
continue; | ||
} | ||
out->set_dtype(ids[0]->dtype()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个output不需要设置dim信息吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个output不需要设置dim信息吗?
原本的InferShape里并没有相关代码,这类Op一般是通过pass插入,不是正常组网得到的,我觉得还是不加为好。
PR types
Others
PR changes
Others
Description
No.2 distributed_push_sparse