Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

【PIR Dist Op Reg No.18】 reg lars_momentum #60838

Merged
merged 11 commits into from
Feb 1, 2024

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 16, 2024

PR types

Others

PR changes

Others

Description

Copy link

paddle-bot bot commented Jan 16, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 16, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 16, 2024
@xingmingyyj
Copy link
Contributor

/paddle/paddle/fluid/pybind/ops_api.cc:4721:12: error: ???eager_api_lars_momentum_??? was not declared in this scope

这里需要把lars_momentum_和lars_momentum加入到paddle/fluid/pir/dialect/op_generator/ops_api_gen.py中的NO_NEED_GEN_STATIC_ONLY_APIS列表中

Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以这样修改试试,我本地可以通过编译及相关单测

Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enkilee hello,之前的问题花了点时间,主要原因是执行器在构建Context时对optional类型变量的处理有一些问题,我在 #61314 进行了修复,该PR已经合入。不过还有一点修改需要处理下,你可以再修改提交下看看。

@kangguangli kangguangli merged commit 32ca78a into PaddlePaddle:develop Feb 1, 2024
30 checks passed
@enkilee enkilee deleted the PIR-optest-fix-18 branch January 8, 2025 08:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants