【Fix PIR Unittest No.38 BUAA】fix TruncatedNormalInitializer according to NormalInitializer and fix test_cuda_random_seed #66413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
BHmingyang
changed the title
Comment on lines
237
to
239
| assert not ( | ||
| isinstance(var, framework.EagerParamBase) and var.is_dist() | ||
| ), "Currently, normal initializer not support lazy init for dist param." |
| block = self._check_block(block) | ||
|
|
||
| assert isinstance(var, framework.Variable) |
There was a problem hiding this comment.
assert isinstance(var, (framework.Variable, paddle.pir.Value))
这个也应该加上。
There was a problem hiding this comment.
assert isinstance(var, (framework.Variable, paddle.pir.core.ParameterMeta))
我打印了一下type(var)，发现它是paddle.pir.core.ParameterMeta。
使用assert isinstance(var, (framework.Variable, paddle.pir.Value))过不了
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jul 25, 2024
… to NormalInitializer and fix test_cuda_random_seed (PaddlePaddle#66413) * fix TruncatedNormalInitializer according to NormalInitializer * change the assertion * fix the code style
44 tasks
inaomIIsfarell
pushed a commit
to inaomIIsfarell/Paddle
that referenced
this pull request
Jul 31, 2024
… to NormalInitializer and fix test_cuda_random_seed (PaddlePaddle#66413) * fix TruncatedNormalInitializer according to NormalInitializer * change the assertion * fix the code style
lixcli
pushed a commit
to lixcli/Paddle
that referenced
this pull request
Aug 5, 2024
… to NormalInitializer and fix test_cuda_random_seed (PaddlePaddle#66413) * fix TruncatedNormalInitializer according to NormalInitializer * change the assertion * fix the code style
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Others
PR Types
Others
Description
assert isinstance(var, (framework.Variable, paddle.pir.core.ParameterMeta))assert isinstance(block, (framework.Block, pir.Block))然后在forward中添加in_pir_mode分支进行pir适配