Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Typing][C-67,C-69,C-71,C-72] Add type annotations for 4 files in python/paddle/incubate/nn/functional/ #66616

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

MikhayEeer
Copy link
Contributor

PR Category

User Experience

PR Types

Improvements

Description

类型标注:
python\paddle\incubate\nn\functional\blha_get_max_len.py
python\paddle\incubate\nn\functional\fused_dot_product_attention.py
python\paddle\incubate\nn\functional\fused_ec_moe.py
python\paddle\incubate\nn\functional\fused_gate_attention.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jul 26, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 26, 2024
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件是不是漏掉了一个函数?统计的数量仅供参考,可能会有一些出入 ~ 可以参考 __init__.py 中的导入关系 ~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢提示,我检查了一下是这样的,之前忽略了该函数,已经新提交了一个commit来完善

…on.py

Co-authored-by: megemini <megemini@outlook.com>
@SigureMo SigureMo changed the title [Typing][C-67,C-69,C-71,C-72] Add type annotations for python\paddle\incubate\nn\functional\* [Typing][C-67,C-69,C-71,C-72] Add type annotations for 4 files in python/paddle/incubate/nn/functional/ Jul 28, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 6a75bf1 into PaddlePaddle:develop Jul 29, 2024
31 checks passed
inaomIIsfarell pushed a commit to inaomIIsfarell/Paddle that referenced this pull request Jul 31, 2024
…thon/paddle/incubate/nn/functional/` (PaddlePaddle#66616)

---------

Co-authored-by: megemini <megemini@outlook.com>
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Aug 5, 2024
…thon/paddle/incubate/nn/functional/` (PaddlePaddle#66616)

---------

Co-authored-by: megemini <megemini@outlook.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants