[CINN][Backend Pass Update No.9] Update RemoveScheduleBlock pass #70334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
|
把注释迁移过来吧😂 |
Comment on lines
60
to
71
| void VisitExpr(ir::Expr* expr) { | ||
| if (expr->is_var()) { | ||
| if (expr->as_var()->name == var_->name && (do_replace_ || visit_all_)) { | ||
| Expr copied = ir::ir_utils::IRCopy(expr_); | ||
| *expr = copied; | ||
| } | ||
| return; | ||
| } | ||
| for (auto field : (*expr)->expr_fields()) { | ||
| VisitExpr(field); | ||
| } | ||
| } |
There was a problem hiding this comment.
Expr也不用特殊实现了，直接调用默认visit函数就行
There was a problem hiding this comment.
默认Visit是指 IRMutator::Visit嘛，不是说升级以后的Visit会被删除嘛？
There was a problem hiding this comment.
Expr也不用特殊实现了，直接调用默认visit函数就行
BTW，为啥原来的Mutator的Visit方法都要传两个参数进去，不太理解
There was a problem hiding this comment.
默认Visit是指
IRMutator::Visit嘛，不是说升级以后的Visit会被删除嘛？
升级之后，属于Stmt的visit函数会被删除，但是Expr还是必须按照这种方式访问，我们后续会把IRMutator的visit限定在Expr。原来的Visit方法传两个参数是为了区分const访问和非const访问，但是这种实现方式确实设计得有点奇怪。
There was a problem hiding this comment.
OK，已经改过了，麻烦您再看一下
liuruyan
approved these changes
Dec 23, 2024
Hongqing-work
approved these changes
Dec 23, 2024
74 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
改造了 RemoveScheduleBlock pass