Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix undefined save_model_dir when using wandb #10251

Merged
merged 2 commits into from
Jun 30, 2023
Merged

fix undefined save_model_dir when using wandb #10251

merged 2 commits into from
Jun 30, 2023

Conversation

itasli
Copy link
Contributor

@itasli itasli commented Jun 27, 2023

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Jun 27, 2023

Thanks for your contribution!

shiyutang
shiyutang requested changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thanks for your contribution but I do not see the point of changing the variable name, and it is not correct because save_dir is used in the following code. image

@itasli
Copy link
Contributor Author

itasli commented Jun 29, 2023

Hello, Thanks for your contribution but I do not see the point of changing the variable name, and it is not correct because save_dir is used in the following code. image

Hey thanks for you reply, actually I wanted to keep the change consistent with the rest of the code and use save_model_dir, but indeed we can also keep save_dir and modify only line 688.

@itasli itasli requested a review from shiyutang June 29, 2023 10:05
shiyutang
shiyutang approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyutang shiyutang merged commit 4b275f1 into PaddlePaddle:release/2.6 Jun 30, 2023
@shiyutang
Copy link
Collaborator

shiyutang commented Jun 30, 2023 •
edited
Loading

Hi, We are now having the contribute to the OCR and Seg activity, you are welcome to join: #10223

You can fix the some issues to participate our activity.

shiyutang pushed a commit that referenced this pull request Aug 23, 2023
@itasli
fix undefined save_model_dir when using wandb (#10251) (#10709)
71b7c45 
* fix undefined save_model_dir when using wand

* Update program.py
shiyutang pushed a commit that referenced this pull request Aug 30, 2023
@itasli
Cherrypicking GH-10251 & GH-10181 to PaddleOCR:dygraph (#10710)
66461c3 
* fix undefined save_model_dir when using wandb (#10251)

* fix undefined save_model_dir when using wand

* Update program.py

* Fix fitz camelCase deprecation and .PDF not being recognized as pdf file (#10181)

* Fix fitz camelCase deprecation and .PDF not being recognized as pdf file

* refactor get_image_file_list function
gknor-edrone pushed a commit to edrone/PaddleOCR that referenced this pull request Sep 9, 2024
@itasli @gknor-edrone
fix undefined save_model_dir when using wandb (PaddlePaddle#10251) (P…
f93f078 
…addlePaddle#10709)

* fix undefined save_model_dir when using wand

* Update program.py
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@shiyutang shiyutang shiyutang approved these changes

Assignees

@itasli itasli

Labels
contributor
Projects
PaddleOCR/release 2.7
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itasli @shiyutang