Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[Compat][3.11] support POP_JUMP for is None and is not None #377

Merged
merged 1 commit into from
Sep 5, 2023
Merged

[Compat][3.11] support POP_JUMP for is None and is not None #377

merged 1 commit into from
Sep 5, 2023

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Sep 5, 2023 •
edited
Loading

因为 3.11 增加了 POP_JUMP_IF_*_NONE 和 POP_JUMP_IF_*_NOT_NONE，对于大多数情况来说它们不是 Constant 和 Container，因此会 Fallback

这里利用 dispatch 消除了 Constant 和 Container 的特判，POP_JUMP 相比于之前支持的情况应该会更多了

启用如下单测：

  • test_guard_user_defined_fn ❌ -> ✅
  • test_resnet ❌ -> ✅

@paddle-bot
Copy link

paddle-bot bot commented Sep 5, 2023

Thanks for your contribution!

2742195759
2742195759 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@2742195759 2742195759 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo requested review from zrr1999 and gouzil September 5, 2023 12:29
@SigureMo SigureMo merged commit 1e46cf3 into develop Sep 5, 2023
@SigureMo SigureMo deleted the py311/support-pop-jump-with-other-object branch September 5, 2023 14:31
@SigureMo SigureMo mentioned this pull request Sep 7, 2023
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@2742195759 2742195759 2742195759 approved these changes

@gouzil gouzil gouzil approved these changes

@zrr1999 zrr1999 Awaiting requested review from zrr1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SigureMo @2742195759 @gouzil