Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Docathon][Add CN Doc No.23] #6372

Merged
merged 11 commits into from
Jan 18, 2024
Merged

[Docathon][Add CN Doc No.23] #6372

merged 11 commits into from
Jan 18, 2024

Conversation

zade23
Copy link
Contributor

@zade23 zade23 commented Dec 8, 2023

PR types

Others

PR changes

Docs

Description

中文文档添加任务

#6193

新增中文文档：

  • paddle.static.ctr_metric_bundle

英文文档链接：

序号 API名称 英文文档地址
23 paddle.static.ctr_metric_bundle https://www.paddlepaddle.org.cn/documentation/docs/en/develop/api/paddle/static/ctr_metric_bundle_en.html

包含修改Overview

@liudongxue01 @sunzhongkai588

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 8, 2023

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-6372.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

@luotao1 luotao1 mentioned this pull request Dec 8, 2023
Closed
@zade23 zade23 mentioned this pull request Dec 8, 2023
Closed
26 tasks
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 8, 2023
@danleifeng
Copy link
Contributor

danleifeng commented Jan 15, 2024 •
edited
Loading

  1. 英文文档可能一直没有更新，辛苦再补充一下2个返回值吧，感谢
    local_pos_num (Tensor) - 局部正例数
    local_ins_num (Tensor) - 局部样本数
    https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/static/nn/metric.py#L589

danleifeng
danleifeng reviewed Jan 15, 2024
View reviewed changes
docs/api/paddle/static/ctr_metric_bundle_cn.rst Outdated

返回类型
::::::::::::
local_sqrerr(Tensor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成返回tuple元组数据类型吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成返回tuple元组数据类型吧

Done，这里参考paddle.sparse.nn.functional.conv3d的返回类型格式进行修改，即：仅写明数据类型。

还有一类返回类型格式为paddle.linalg.pca_lowrank一类，即：归类在返回一栏中标明元组中的参数。

麻烦开发者看一下是否需要改成第二种类型

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成返回tuple元组数据类型吧

Done，这里参考paddle.sparse.nn.functional.conv3d的返回类型格式进行修改，即：仅写明数据类型。

还有一类返回类型格式为paddle.linalg.pca_lowrank一类，即：归类在返回一栏中标明元组中的参数。

麻烦开发者看一下是否需要改成第二种类型

改成第二种类型吧，更加准确直观一点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zade23 zade23 requested a review from danleifeng January 17, 2024 03:49
danleifeng
danleifeng approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@danleifeng danleifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要不顺便把英文的也更新了

@zade23 @sunzhongkai588
Update docs/api/paddle/static/ctr_metric_bundle_cn.rst
5ebc7ae 
Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
@zade23 zade23 mentioned this pull request Jan 17, 2024
Merged
@zade23
Copy link
Contributor Author

zade23 commented Jan 17, 2024

要不顺便把英文的也更新了

PaddlePaddle/Paddle#60912

sunzhongkai588
sunzhongkai588 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 01bdb6e into PaddlePaddle:develop Jan 18, 2024
2 checks passed
@zade23 zade23 deleted the en_doc_23 branch January 18, 2024 03:49
@zade23 zade23 mentioned this pull request Jan 22, 2024
Closed
24 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danleifeng danleifeng danleifeng approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@danleifeng danleifeng

@sunzhongkai588 sunzhongkai588

Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zade23 @danleifeng @sunzhongkai588 @luotao1