Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create unittests for switchmap/dashboard/table/search.py #207

Open
palisadoes opened this issue Jan 2, 2025 · 10 comments
Open

Create unittests for switchmap/dashboard/table/search.py #207

palisadoes opened this issue Jan 2, 2025 · 10 comments

Comments

@palisadoes
Copy link
Contributor

We will need unittests done for all methods, classes and functions found in this file.

PR Acceptance Criteria

  1. When complete this file must show 100% coverage when merged into the code base.
  2. The current code coverage for the file can be found here
  3. CodeRabbit must approve all your changes to the test file(s) and the file(s) under test
  4. The PR will show a report for the code coverage for the file you have added. You can use that as a guide
  5. No functionality must be removed to achieve this goal
  6. All tests must be valid and truly test the code base
  7. The tests must be placed in the equivalent folder under tests/switchmap_ therefore:
    1. a file named switchmap/x/y/z/file.py must have a test file named tests/switchmap_/x/y/z/test_file.py
    2. file tests/switchmap_/x/y/z/test_file.py must have 755 permissions so it can be easily executable
    3. take guidance on the formatting of the file from other tests/switchmap_/x/y/z/test_*.py files or others along the path or in adjacent directories

Other Criteria

  1. If this file isn't referenced in the code base then remove it. We don't want tests run on unused code

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Ramneet04
Copy link

@palisadoes hey I have minimal knowledge of python but yeah I feel I can do it, please assign it to me.

@Cioppolo14
Copy link

@Ramneet04 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@VanshikaSabharwal
Copy link

Hello @palisadoes @Cioppolo14 I have raised PR for 1 of my issue and it is passing all tests.
PalisadoesFoundation/talawa-admin#2615 (comment)
So it might get merged soon. SO Can i work on this issue as i have wrote the test. I have attached ss.
This is the passing test logs.
image
This is the test file code.
image

So. Can you please assign me this issue.

@Cioppolo14
Copy link

@VanshikaSabharwal Our current policy sticks to keeping 2 issues per person, even if those issues are in PR review status. Once one is merged, let me know and we can assign you.

@VanshikaSabharwal
Copy link

VanshikaSabharwal commented Jan 5, 2025

Yes Sure @Cioppolo14 I'll let you know.

@syedali237
Copy link

Can I be assigned this issue?

@VanshikaSabharwal
Copy link

@syedali237 I have already solved this issue. So, Can you please take any other similar issue. Doing that would be really generous of you.

@syedali237
Copy link

@VanshikaSabharwal okay, no worries!!

@VanshikaSabharwal
Copy link

Yes @syedali237 Thank you so much

@VanshikaSabharwal
Copy link

@Cioppolo14 @palisadoes Can you please assign me this issue now as i have merged another issue. Thus i am now eligible to take one more issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants