Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Performance issue in /slim/datasets (by P3) #30

Open
DLPerf opened this issue Aug 25, 2021 · 1 comment
Open

Performance issue in /slim/datasets (by P3) #30

DLPerf opened this issue Aug 25, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 25, 2021

Hello! I've found a performance issue in download_and_convert_cifar10.py: with tf.Session('') as sess(here) is defined in the function _add_to_tfrecord(here) which is repeatedly called in the loop for i in range(_NUM_TRAIN_FILES)(here).

tf.Session being defined repeatedly could lead to incremental overhead. If you define tf.Session out of the loop and pass tf.Session as a parameter to the loop, your program would be much more efficient. Here is the Stack Overflow post to support it.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf
Copy link
Author

DLPerf commented Nov 4, 2021

Hello, I'm looking forward to your reply~

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant